Home › Forums › Feature Requests / Enhancements

Improving the "cycle through proxies" mode

Thu, 08/27/2009 - 08:27 — Pascal G.

Hi,
 
Would it be possible to restrict the cycle through proxies mode to declared proxies only, i.e to "default" and whatever other proxies that the user has defined ? In the current version this mode also cycles through the two options "deactivate FoxyProxy" and "pattern-based proxy" which I think are not relevant at all in that mode.
 
Also, the great benefit of restricting to declared proxies would be that in the case where the user has defined only one proxy, then it would become possible to switch between "default" and the defined proxy in a single click on the FoxyProxy icon in the status bar !
 
Thanks,
 
 
    Pascal G.
 

‹ PayPal Payments Dont open 'new features' page after every update ›
Fri, 08/28/2009 - 14:26 — ericjung

Hi Pascal, Yes, this was my

Hi Pascal,

Yes, this was my original intention with "cycle through proxies", but I never got around to fully implementing it. It's still a good idea, I think.

I've added it to my "TODO" list so I don't forget. Just don't expect it in the next release unless someone else can work on it (hint, hint... are you a developer? I can help you and show you what exactly needs to be changed)

Eric

Mon, 08/31/2009 - 09:14 — Pascal G.

Hi Eric,   Thanks for your

Hi Eric,
 
Thanks for your answer. I used to be a developer but that was a long time ago... However, I'm still working in the software industry, so I get regular code exposure with the developers I'm working with and I might be able to do this myself. Can I have a look at your code to see how much work is needed and how difficult this could be ? I guess I need to install some kind of SDK too ? Let me check the documentation on FireFox addons...
 
    Pascal.

Sun, 01/24/2010 - 15:45 — wkearney99

Progress?

Is there a way to disable using patterns when cycling via the statusbar?

I just want to cycle between a set of proxies and disabled. I do not want to use patterns at all. Just cycle from one active proxy, to the next, to disabled and then back to the next active proxy.

Can you give an explanation of what the cycleMode function is doing in foxyproxy.js? I gather that'd be the place to make some changes to disable cycling through patterns, right?

Sun, 01/24/2010 - 23:10 — ericjung

Yes, cycleMode() is the

Yes, cycleMode() is the correct place to change this.
See http://fisheye2.atlassian.com/browse/foxyproxy/trunk/src/components/foxy...

So what you should do is change lines 280-283 from:

Quote:

else if (this._mode == "disabled") {
this.setMode(this.isFoxyProxySimple() ?
/* FP Simple has no "patterns" mode, so skip to next one */_getNextAfterPatterns() : "patterns", true);

to:

Quote:

this.setMode(_getNextAfterPatterns(), true);

This effectively skips "patterns" mode entirely. The issue with making this a long-term change is that there needs to be a GUI setting for it somewhere, as well as the ability to persist the GUI selection.

Eric

Mon, 02/01/2010 - 19:55 — qwerw

Two click context manual instead of cycling

I have a long list of proxies because some free proxies do not support posting, and some are extremely busy at part of the day.  I also try to maintain some sort of different identities by using different proxies in different countries.  Using the context menu to select proxy is faster.  At the moment it's 3 clicks to select a proxy.  It's pretty annoying when you do it many times a day, when the 3rd click isn't really have any functionality.  It doesn't get simpler for the Basic version when URL pattern is not supported at all.  You don't have the problem if you pay for a reliable proxy, but the payment leave trails. 

Tue, 02/02/2010 - 02:41 — ericjung

I went to add this to

I went to add this to FoxyProxy today, and realized that the original request is already there. On the Proxy Settings - General Tab (where you enter a name and notes for the proxy), there is a checkbox:

Quote:

Include this proxy when cycling proxies by clicking on statusbar or toolbar ...

You can check/uncheck this per proxy to affect the order.

Are you asking for the ability to eliminate "disabled" and "patterns" from the cycling? If so, that isn't hard to add. Let me know.

Eric

Tue, 02/02/2010 - 03:16 — ericjung

Hi, I have a beta for this.

Hi, I have a beta for this. Can you test it? Please email me at eric dot jung at yahoo dot com.

Thank you,
Eric

Tue, 02/16/2010 - 03:11 — ericjung

Hi, This was done in

Hi,

This was done in FoxyProxy Standard 2.19 and FoxyProxy Basic 1.6. From the release notes:

Quote:

Two new hidden settings: excludePatternsFromCycling and excludeDisabledFromCycling. To use: close firefox. In foxyproxy.xml, change the new "excludePatternsFromCycling" and/or "excludeDisabledFromCycling" attribute from its default of "true" to "false".

Eric

Tue, 02/16/2010 - 13:03 — Pascal G.

Thanks !

Just tried the new version 2.19. The cycling between "default" and my company proxy is much better now. I can switch between the proxy and no proxy in a single click. Brilliant ! Thanks !!!

Tue, 02/16/2010 - 15:47 — harnack

excludeDisabledFromCycling doesn't take effect

I set "excludeDisabledFromCycling" to true but it doesn't take effect.

Tue, 02/16/2010 - 22:44 — ericjung

Harnack, I got your email

Harnack, I got your email with foxyproxy.xml file. I've reproduced the bug with your XML file and will fix as soon as possible.

Thanks for your patience,
eric

Wed, 02/17/2010 - 02:58 — harnack

Thanks!

Thank you very much!