FoxyProxy messes with the Google Toolbar search history
Hi there.
It seems there's some interaction between FP and the (official) Google Toolbar that's preventing the Toolbar from saving its search history between browser sessions (stored in searchhistory.xml in the profile's GoogleToolbarData subfolder). The already existing search history stays put, but as soon as FP is enabled (in Add-ons, not proxying-wise), any new search queries no longer get saved. This only seems to affect this particular Toolbar functionality, the search URLs do show up in Firefox's own history.
I stepped back through the versions and whatever is causing this seems to have been introduced in FP 2.8.6; 2.8.5 is OK. Which figures, as I'm pretty sure my previous version was 2.8.5 until I updated my add-ons last week or so and started noticing this problem. Other extensions don't seem to matter, this happens even with FP and the Toolbar being the only extensions in the profile.
Versions:
FoxyProxy 2.8.6-2.8.9
Google Toolbar for Firefox 3.1.20081127W
Firefox/3.0.4 Gecko/2008102920
Windows XP SP3
Hopefully you can come up with a workaround with this information, but in any case thanks for all your hard work developing this extremely useful extension I use daily.
Work-around
This turned out to be related to another more serious issue. See this discussion for a follow-up and a potential work-around we found.
Seems to be fixed
Whatever you did to fix the plugins problem in 2.8.11 seems to have fixed this one too.
Since you didn't mention that in your report, I wonder if I should mention in the Bugzilla discussion that whatever caused the plugins problem seems to have caused this issue as well? The point being that they've now classified that bug as a plugins bug, but I'm not sure what Google Toolbar not being able to save its config file would have to do with plugins. (I've never posted at Bugzilla before so I'd have to register etc., otherwise I'd just do it without waffling about it here.)
Hi, I'm not able to
Hi,
I'm not able to reproduce the bug you describe with Google Toolbar search history using the reenableplugins.xpi I created at https://bugzilla.mozilla.org/show_bug.cgi?id=471245. I installed Google Toolbar first, then reenableplugins.xpi. My search history in the toolbar looks fine (the drop-down list of previous search results is there).
Eric
By the way, the Google
By the way, the Google Toolbar may indeed be a plugin. Plugins can be bundled inside of extensions. I didn't get a chance to look at Google Toolbar's XPI to see if that's what they're doing.
Packaging?
Isn't that just talking about packaging, though? I mean, you'd think a plugin would still have to show up in Add-ons->Plugins and about:plugins.
Hmm...
Just to be sure, did you try the same version I did? I haven't installed the ver. 5 beta yet, I have 3.1.20081127W. The problem was there with your flattened reenableplugins.xpi, the jar'ed one didn't have it.
BTW, the problem I had was not that the previous search results disappeared, but that any new searches were no longer getting added to the list beyond the current session, i.e. after restarting FF I didn't have the searches from the last usage session, only those from before the culprit .xpi was enabled always stayed put. In other words the saved search history .xml file was no longer getting updated. (Since you said "the drop-down list of previous search results is there", I'm not 100% sure you tested for the same thing.)
Since you've already fixed this problem, I wouldn't otherwise be concerned with this, but this issue of not updating the search history file seems different enough from the issue with plugins. After all, the saved plugins cache file was being updated, albeit with incorrect enablement values. And since the existing history file is being read OK, the problem seems to be happening at the end of the session, not at the beginning.
You are right, I didn't test
You are right, I didn't test the same thing as you... because you didn't give the kind of detail about exactly what was broken until just now. I'll try it again and, yes, I was using 3.1.2.0081127W. If I can recreate the problem, I'll add the info the bugzilla bug. I suspect I'll be told to file a new bug. If that happens, I'm not particularly interested in pursuing it any farther because this is a bug with Google Toolbar (something I don't even use and never installed until today).
I don't know if plugins bundled as XPIs would appear in the about:plugins list, but I will find out.
In that case, sorry
> because you didn't give the kind of detail about exactly what was broken until just now.
Well, I initially said "preventing the Toolbar from saving its search history between browser sessions" and "The already existing search history stays put, but as soon as FP is enabled (in Add-ons, not proxying-wise), any new search queries no longer get saved." I guess I could have been more detailed, and for some reason it didn't occur to me that you might have to install something you've never used.
Anyway, thanks for looking into it some more. If it weren't the case that this problem appeared and disappeared under the same conditions as the plugins problem, I wouldn't have asked you to do anything more. I just think knowing about this might be helpful for them in fixing the underlying issue(s), not so much for you in terms of FP. It may be a Toolbar bug, but it could be a FF issue like it was with your thing.
Done:
Done: https://bugzilla.mozilla.org/show_bug.cgi?id=471245#c29
Thanks!
^
|
|